create test for output_requirements#395
Merged
alan-barzilay merged 1 commit intobndr:nextfrom Oct 4, 2023
firilisinof:output_requirements_next
Merged
create test for output_requirements#395alan-barzilay merged 1 commit intobndr:nextfrom firilisinof:output_requirements_next
alan-barzilay merged 1 commit intobndr:nextfrom
firilisinof:output_requirements_next
Conversation
alan-barzilay
requested changes
Sep 27, 2023
Collaborator
alan-barzilay
left a comment
There was a problem hiding this comment.
Dont forget to rebase your PR
Contributor
Author
|
I just updated the PR description with more details. |
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## next #395 +/- ##
=======================================
Coverage ? 89.27%
=======================================
Files ? 2
Lines ? 261
Branches ? 0
=======================================
Hits ? 233
Misses ? 28
Partials ? 0 ☔ View full report in Codecov by Sentry. |
alan-barzilay
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a test for the
output_requirementsfunction.