feat: adding custom/default user agent support for http monitors#3446
Open
akashmannil wants to merge 6 commits into
Open
feat: adding custom/default user agent support for http monitors#3446akashmannil wants to merge 6 commits into
akashmannil wants to merge 6 commits into
Conversation
ajhollid
requested changes
Mar 27, 2026
Collaborator
ajhollid
left a comment
There was a problem hiding this comment.
There's two major issues here
- Excess DB access
- Header injection
that need to be addressed. There's also an architectural tweak that can keep HttpProvider less tightly coupled.
Please have a look at my comments in the code review, thanks!
c055c3d to
fd79163
Compare
9df50ba to
ae85af2
Compare
ajhollid
requested changes
Apr 7, 2026
Collaborator
ajhollid
left a comment
There was a problem hiding this comment.
TimescaleDB implementation is missing, and it appears that the user agent will be cleared on unrelated setting change. Can you please verify that?
Collaborator
Author
|
Made changes @ajhollid. Please do let me know if it looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom and Default User agent support for monitoring.
Checkmate/X.X (uptime monitor; your-instance)- Placeholder added keeping in mind of the local checkmate instance. Please do let me know if changes neededImplements #3260
Please ensure all items are checked off before requesting a review. "Checked off" means you need to add an "x" character between brackets so they turn into checkmarks.
<div>Add</div>, use):npm run formatin server and client directories, which automatically formats your code.