stores: mainVehicle: expose autopilot info on the data-lake#2478
Open
ES-Alexander wants to merge 1 commit intobluerobotics:masterfrom
Open
stores: mainVehicle: expose autopilot info on the data-lake#2478ES-Alexander wants to merge 1 commit intobluerobotics:masterfrom
ES-Alexander wants to merge 1 commit intobluerobotics:masterfrom
Conversation
rafaellehmkuhl
approved these changes
Apr 9, 2026
Member
rafaellehmkuhl
left a comment
There was a problem hiding this comment.
Nice addition!
I have some points but none of them being blockers. The only one I believe it would be nice to decide upfront would be item 1, around the variable ID.
- Does it make sense to have the
cockpit/in the beginning of the ID? I believe your idea here is that it's an information that comes from the vehicle but is actually created via parsing and some logic by Cockpit, right? Feels to me that from that logic almost everything would be considered to need acockpit/prefix. It makes more sense to me that it starts simply withvehicle/, as Cockpit is always parsing something somehow. - The
mainVehicle.tsis indeed not the bast place as we are moving away from it, but at the same time we introduced a lot of logic there recently, so I don't think its the end of the world. If you accept a suggestion, I think it could fit well on/src/libs/vehicle. - It would be nice to move the
AutopilotVersionparsing logic to a file dedicated to MAVLink stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to use information about the vehicle/firmware that is currently being controlled, for things like extensions of #2476.
I'm unsure whether there are issues with updating this in the mainVehicle stores - IIRC we're trying to migrate away from that to some extent? Not sure what the deal is 🤷♂️
I considered implementing this in the vehicle factory, but there's a bit of infra missing, and then there's no updating after the initial connection (which could cause issues if the user switches which vehicle type they're controlling).