Skip to content

stores: mainVehicle: expose autopilot info on the data-lake#2478

Open
ES-Alexander wants to merge 1 commit intobluerobotics:masterfrom
ES-Alexander:expose-autopilot-info
Open

stores: mainVehicle: expose autopilot info on the data-lake#2478
ES-Alexander wants to merge 1 commit intobluerobotics:masterfrom
ES-Alexander:expose-autopilot-info

Conversation

@ES-Alexander
Copy link
Copy Markdown
Contributor

I want to use information about the vehicle/firmware that is currently being controlled, for things like extensions of #2476.

I'm unsure whether there are issues with updating this in the mainVehicle stores - IIRC we're trying to migrate away from that to some extent? Not sure what the deal is 🤷‍♂️

I considered implementing this in the vehicle factory, but there's a bit of infra missing, and then there's no updating after the initial connection (which could cause issues if the user switches which vehicle type they're controlling).

@ES-Alexander ES-Alexander marked this pull request as ready for review March 7, 2026 17:31
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Mar 27, 2026
Copy link
Copy Markdown
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

I have some points but none of them being blockers. The only one I believe it would be nice to decide upfront would be item 1, around the variable ID.

  1. Does it make sense to have the cockpit/ in the beginning of the ID? I believe your idea here is that it's an information that comes from the vehicle but is actually created via parsing and some logic by Cockpit, right? Feels to me that from that logic almost everything would be considered to need a cockpit/ prefix. It makes more sense to me that it starts simply with vehicle/, as Cockpit is always parsing something somehow.
  2. The mainVehicle.tsis indeed not the bast place as we are moving away from it, but at the same time we introduced a lot of logic there recently, so I don't think its the end of the world. If you accept a suggestion, I think it could fit well on /src/libs/vehicle.
  3. It would be nice to move the AutopilotVersion parsing logic to a file dedicated to MAVLink stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-needed Change needs to be documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose autopilot firmware information in the data-lake We don't have vehicle identification data anywhere

2 participants