Skip to content

fix: migrate drifted Proto Fleet UI primitives#736

Merged
jmarrxyz merged 4 commits into
mainfrom
codex/drift-implementation-cleanup
Jul 14, 2026
Merged

fix: migrate drifted Proto Fleet UI primitives#736
jmarrxyz merged 4 commits into
mainfrom
codex/drift-implementation-cleanup

Conversation

@jmarrxyz

Copy link
Copy Markdown
Contributor

Summary

  • Migrate firmware upload/update cleanup to design-system tokens and Button treatments.
  • Replace the alerts single picker with the shared Select primitive, and add Select placeholder/empty-state support.
  • Replace BuildingCard's bespoke row-actions popover with RowActionsMenu while preserving card navigation behavior.
  • Tokenize copy-secret buttons, typography drift, footer/critical/rack-status colors, and rack slot labels.

Test plan

  • ../bin/npm exec prettier -- --write
  • ../bin/npm exec vitest -- run src/protoFleet/features/buildings/components/BuildingCard.test.tsx src/protoFleet/features/fleetManagement/components/RowActionsMenu/RowActionsMenu.test.tsx src/protoFleet/features/settings/components/CreateApiKeyModal.test.tsx src/protoFleet/features/settings/components/ResetPasswordModal.test.tsx src/protoFleet/features/fleetManagement/components/MinerActionsMenu/FirmwareUpdateModal/FirmwareUpdateModal.test.tsx src/protoFleet/features/fleetManagement/components/MinerList/MinerName.test.tsx
  • ../bin/npm exec eslint -- --max-warnings 0
  • ../bin/npm exec tsc -- --noEmit
  • Storybook visual QA on localhost:6008 via headless Chrome: BuildingCard menu, firmware upload/update modals, reset-password copy state, RackDetailGrid states, RackSlotGrid states.

Local note

Full repo lint is blocked in this temporary worktree by stale borrowed dependencies (installed prettier 3.8.4 vs lockfile 3.9.4), which reports Prettier drift in untouched files. A fresh npm ci could not complete locally because registry tarballs were returning integrity failures, so this PR was pushed with hooks skipped after the targeted checks above.

@jmarrxyz jmarrxyz requested a review from a team as a code owner July 10, 2026 22:27
@github-actions github-actions Bot added javascript Pull requests that update javascript code client review-policy: needs-review Managed by the Review Policy workflow. labels Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated security-focused code review generated by Codex.
It should be used as a supplementary check alongside human review.
False positives are possible - use your judgment.

Scope summary

  • Reviewed pull request diff only (7f084a1a9f7636694833b82c1165da8e6d2c04d6...9103efbb9380021484b3ec9cb56302175f59a93b, exact PR three-dot diff)
  • Model: gpt-5.5

💡 Click "edited" above to see previous reviews for this PR.


Review Summary

Overall Risk: NONE

Findings

No security, correctness, or reliability findings were identified in the reviewed diff.

Notes

Reviewed .git/codex-review.diff as the authoritative scope. The changes are limited to frontend UI/component behavior and styling, with no changed authentication, backend RPC/database paths, plugin execution, network discovery, infrastructure, protobuf wire format, or mining pool configuration logic.


Generated by Codex Security Review |
Triggered by: @jmarrxyz |
Review workflow run

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4dfcfc440

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread client/src/protoFleet/features/buildings/components/BuildingCard.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a996661d8e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a1ffb0b5a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@flesher flesher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@github-actions github-actions Bot added review-policy: human-approved Managed by the Review Policy workflow. and removed review-policy: needs-review Managed by the Review Policy workflow. labels Jul 14, 2026
@jmarrxyz jmarrxyz merged commit 40147f3 into main Jul 14, 2026
54 checks passed
@jmarrxyz jmarrxyz deleted the codex/drift-implementation-cleanup branch July 14, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client javascript Pull requests that update javascript code review-policy: human-approved Managed by the Review Policy workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants