Renovate pre-commit + CI a bit #1841
Conversation
(with `uvx gha-tools@latest autoupdate --pin third-party -s specific --first-party-version-strategy=major --write .github/workflows/`)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| -w /src -v "$PWD:/src" "$image" sh -c \ | ||
| "apt-get update \ | ||
| && pip install cmake==3.31.6 \ | ||
| && uv tool install cmake==3.31.6 \ |
There was a problem hiding this comment.
The ROCm docker images likely won't have uv installed, and that's not covered by a setup-uv action running on the host. I recognize the advantage of using uv but in this case it's probably not worth changing since installing cmake is < 1% of the build runtime.
| fi | ||
|
|
||
| [[ "${build_os}" = windows-* ]] && python3 -m pip install ninja | ||
| uv tool install ninja cmake==3.28.3 |
There was a problem hiding this comment.
This will install on the host for both Windows and Linux, but on Linux we end up using a container with cmake installed via dnf. We only would need this on Windows, so I think it makes sense to move to line 44 below.
| - uses: astral-sh/setup-uv@61cb8a9741eeb8a550a1b8544337180c0fc8476b | ||
| with: | ||
| python-version: '3.14' |
There was a problem hiding this comment.
See comment on build-rocm.sh; because we build in a container we shouldn't need to install python on the host.
|
@akx Thanks! These are welcome changes! Left some comments, but will be happy to merge when it's ready! |
2 participants
Happy 2026!
Just some minor-ish CI pipeline and lint fixes (for now 😇):
uvto install Python and tools (faster!)pre-commit-uv(faster!) (prekis also an option)