Open
Conversation
Member
Author
|
Rebased. Added a commit that re-enables the now-fixed benchmarks in CI. |
sipa
reviewed
Oct 21, 2025
| std::vector<uint64_t> roots(2 * syndromes); | ||
| std::random_device rng; | ||
| std::uniform_int_distribution<uint64_t> dist(1, (uint64_t(1) << bits) - 1); | ||
| uint64_t upper_bound; |
Collaborator
There was a problem hiding this comment.
There is a simpler way:
auto upper_bound = std::numeric_limits<uint64_t>::max() >> (64 - bits);
From https://en.cppreference.com/w/c/language/operator_arithmetic.html: > The behavior is undefined if rhs is negative or is greater or equal > the number of bits in the promoted lhs. Co-authored-by: Pieter Wuille <[email protected]>
hebasto
force-pushed
the
250602-bench-ub
branch
from
b0919e1 to
a436966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://en.cppreference.com/w/c/language/operator_arithmetic.html:
Steps to reproduce on Ubuntu 25.04 using the master branch @ ea8f66b: