refactor: Delete unused ScopedHandle:operator=(ScopedHandle&&)#53
Open
hebasto wants to merge 1 commit intobitcoin-core:bitcoin-forkfrom
Open
refactor: Delete unused ScopedHandle:operator=(ScopedHandle&&)#53hebasto wants to merge 1 commit intobitcoin-core:bitcoin-forkfrom
ScopedHandle:operator=(ScopedHandle&&)#53hebasto wants to merge 1 commit intobitcoin-core:bitcoin-forkfrom
Conversation
hodlinator
approved these changes
Apr 9, 2026
hodlinator
left a comment
hodlinator
left a comment
There was a problem hiding this comment.
ACK 85665f9
Tested on Bitcoin Core at 2b541eeb363cd43fc225c7c7f9691c925b0e4f9d, patching the in-tree file and building Linux->Windows cross build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the unused move-assignment operator to silence the
-Wunused-member-functionwarning emitted by clang-cl:This warning was noted during work on bitcoin/bitcoin#31507, where it was suggested that addressing it might be worthwhile.
Alternatively, the warning could be suppressed downstream, but this change avoids the need for that.
There appears to be little justification for submitting this upstream.