Adds non-mempool wallet balance to overview #911
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
To test, start with from the console. "Non-mempool: " should appear in the Balances pane on the Overview window with the change from the transaction. Restarting with |
Uses send rpc to create a tx with oversized OP_RETURN output, verifies that it doesn't enter the mempool, and that getbalance rpc returns a nonmempool value.
ajtowns
force-pushed
the
202511-wallet-unconf-bal-gui
branch
from
029dc0d to
4be5d3d
Compare
|
Screenshot: 
The negative sign for the non-memool stuff isn't really very clear, perhaps. |
ajtowns
force-pushed
the
202511-wallet-unconf-bal-gui
branch
from
4be5d3d to
bc85b4a
Compare
2 participants
The wallet can contain transactions that are not accepted into the node's mempool (eg due to containing a too large OP_RETURN output, due to too low a feerate, or due to too many unconfirmed ancestors). In the event you end up in this situation, it can appear as if funds have gone missing from your wallet due to the non-mempool balance not being reported. Correct this by reporting the non-mempool balance.
Depends on bitcoin/bitcoin#33671