fix: QML runtime errors - #882
Open
uqlidi wants to merge 4 commits into
Open
Conversation
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bundles four small QML runtime fixes that were opened separately, since each one is a couple of lines plus a test and they are all fixing errors/warnings printed at runtime rather than behaviour changes. Each fix keeps its own commit and its own regression test.
Taken from:
ImportWalletOptionscomputedheroWidthfromparent.width, but the page's parent can be null (it's not always in aStackView), so the binding evaluated onnulland printed a TypeError. Useroot.widthinstead. Fix ImportWalletOptions reads parent.width while parent can be null #868implicitWidth#879:InformationPageandSettingsWalletsized their contentColumnLayoutfromparent.widthinside aFlickablewhosecontentWidthderived from that same content, producingimplicitWidthbinding loops on Qt 6.4. Both pages now set an explicitcontentWidthfrom a fixed maximum-width property and the layout reads that property. Fix Node settings pages report implicitWidth binding loops on Qt 6.4 #866banListModelon click unban #880: Clicking Unban invalidated the delegate mid-handler:handleBannedListChangedemittedbannedListChangedsynchronously, which reset the model and destroyed the delegate before the handler finished, leavingbanListModelundefined. The emit is now queued (Qt::QueuedConnection) and the click handler moved to a function on the page. Fix Synchronous ban-list reset invalidates the Unban click handler #867CoreCheckBoximportorg.bitcoincore.qt#881:CoreCheckBoxusesAppModewithout importingorg.bitcoincore.qt, so the type was unresolved at runtime. Added the missing import. Fix CoreCheckBox uses AppMode without importing org.bitcoincore.qt #865