Skip to content

Fix Qt6.2 compatibality issues - #811

Open
uqlidi wants to merge 1 commit into
bitcoin-core:qt6from
uqlidi:fix/compat/FolderDialog-qt62
Open

Fix Qt6.2 compatibality issues#811
uqlidi wants to merge 1 commit into
bitcoin-core:qt6from
uqlidi:fix/compat/FolderDialog-qt62

Conversation

@uqlidi

@uqlidi uqlidi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

fix the compatibility of the folder dialog component with qt6.2 that causes a failure with ubuntu22.04

Also, added ubuntu22.04 to the CI matrix

fix #783

@hebasto

hebasto commented Jul 24, 2026

Copy link
Copy Markdown
Member

CI fails:

qrc:/test/qml/tst_activity.qml:28:9: Type Activity unavailable 
             Activity { 
             ^
qrc:/qml/pages/wallet/Activity.qml:636:17: Type ContextMenuPicker unavailable 
                     ContextMenuPicker { 
                     ^
qrc:/qml/controls/ContextMenuPicker.qml:5:25: Expected token `;' 
     pragma ComponentBehavior: Bound 
                             ^

Errors while running CTest

50% tests passed, 1 tests failed out of 2

Total Test time (real) =  13.70 sec

The following tests FAILED:
	  2 - bitcoinqml_qmltests (Failed)

@hebasto

hebasto commented Jul 27, 2026

Copy link
Copy Markdown
Member

Converting to draft until CI is green.

@hebasto
hebasto marked this pull request as draft July 27, 2026 14:52
@uqlidi

uqlidi commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

CI fails:

qrc:/test/qml/tst_activity.qml:28:9: Type Activity unavailable 
             Activity { 
             ^
qrc:/qml/pages/wallet/Activity.qml:636:17: Type ContextMenuPicker unavailable 
                     ContextMenuPicker { 
                     ^
qrc:/qml/controls/ContextMenuPicker.qml:5:25: Expected token `;' 
     pragma ComponentBehavior: Bound 
                             ^

Errors while running CTest

50% tests passed, 1 tests failed out of 2

Total Test time (real) =  13.70 sec

The following tests FAILED:
	  2 - bitcoinqml_qmltests (Failed)

pragma ComponentBehavior: Bound was introduced in Qt 6.4 (read: https://doc.qt.io/qt-6/qtqml-documents-structure.html), so it fails to parse under our documented Qt 6.2 minimum. On 6.2 the QML parser reports Expected token ';' at the pragma line. This is what the new Ubuntu 22.04 / Qt 6.2 CI job caught.

There's no pre-6.4 language equivalent of the pragma, so we can't make it version-conditional cleanly (QML has no preprocessor, and gating it via build-time file generation is more machinery than a single lint line justifies).

Removing it is safe because the pragma is only advisory here.

@uqlidi
uqlidi force-pushed the fix/compat/FolderDialog-qt62 branch 3 times, most recently from df2c51e to dea6991 Compare July 31, 2026 06:46
@uqlidi
uqlidi marked this pull request as ready for review July 31, 2026 15:33
@uqlidi

uqlidi commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Ready for review. All issues with Ubuntu 22.04 were solved

@uqlidi uqlidi changed the title fix: FolderDialog compatiability with Qt6.2 Fix Qt6.2 compatibality issues Jul 31, 2026
@uqlidi

uqlidi commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

@hebasto ping

@uqlidi

uqlidi commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@hebasto could you take a look at this when you have the time, please?

Comment thread qml/compat/qt62/AppFolderDialog.qml
@uqlidi
uqlidi force-pushed the fix/compat/FolderDialog-qt62 branch from dea6991 to 620ee82 Compare August 22, 2026 14:12
@uqlidi
uqlidi requested a review from johnny9 August 22, 2026 14:13
ci: add ubuntu22.04

remove `pragma ComponentBehavior: Bound`

fix: `selectedFiles` is read-only with qt6.2

fix the ci failure
@uqlidi
uqlidi force-pushed the fix/compat/FolderDialog-qt62 branch from 620ee82 to f1796dd Compare August 22, 2026 21:18

@johnny9 johnny9 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f1796dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The app fails to start on Ubuntu 22.04

3 participants