-
Notifications
You must be signed in to change notification settings - Fork 53
External signer wallet create and send #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johnny9
wants to merge
11
commits into
bitcoin-core:qt6
Choose a base branch
from
johnny9:external-signer
base: qt6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c209600
qml: add external signer wallet flow
johnny9 945df69
test: add external wallet end-to-end coverage
johnny9 683feb0
wallet: create external signer wallets asynchronously
johnny9 c9c3844
qml: bundle app fonts and use Roboto Mono for addresses
johnny9 aeb84f0
test: add list item support to QML bridge
johnny9 324aa26
qml, test: refine send review pages and coverage
johnny9 bbbef67
qml: add external signer send review flow
johnny9 4e7cc6a
test: add self-registering Qt unit test registry
johnny9 3ee2148
qml: refresh wallet balance on transaction changes
johnny9 72f3511
test: add QML external signer functional coverage
johnny9 22f0b7d
test: add QML test for external signer review actions
johnny9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| // Copyright (c) 2026 The Bitcoin Core developers | ||
| // Distributed under the MIT software license, see the accompanying | ||
| // file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
|
||
| import QtQuick 2.15 | ||
| import QtQuick.Controls 2.15 | ||
| import QtQuick.Layouts 1.15 | ||
|
|
||
| import "../controls" | ||
|
|
||
| Item { | ||
| id: root | ||
|
|
||
| property string labelText: qsTr("Send to") | ||
| property string text: "" | ||
| property string fullText: "" | ||
| property string expandedObjectName: "" | ||
| property bool expanded: false | ||
| property int labelPixelSize: 18 | ||
| property color labelColor: Theme.color.neutral9 | ||
| readonly property bool showLabel: labelText.length > 0 | ||
| readonly property bool expandable: fullText.length > 0 | ||
|
|
||
| Layout.fillWidth: true | ||
| implicitHeight: Math.max(showLabel ? label.implicitHeight + 6 : 0, addressContainer.implicitHeight) | ||
|
|
||
| onExpandableChanged: { | ||
| if (!expandable) { | ||
| expanded = false | ||
| } | ||
| } | ||
|
|
||
| function click() { | ||
| if (expandable && !expanded) { | ||
| expanded = true | ||
| } | ||
| } | ||
|
|
||
| CoreText { | ||
| id: label | ||
| visible: root.showLabel | ||
| width: 110 | ||
| anchors.left: parent.left | ||
| anchors.top: parent.top | ||
| anchors.topMargin: 6 | ||
| horizontalAlignment: Text.AlignLeft | ||
| text: root.labelText | ||
| font.pixelSize: root.labelPixelSize | ||
| color: root.labelColor | ||
| } | ||
|
|
||
| Item { | ||
| id: addressContainer | ||
| anchors.left: root.showLabel ? label.right : parent.left | ||
| anchors.right: parent.right | ||
| anchors.top: parent.top | ||
| implicitHeight: addressColumn.implicitHeight | ||
| height: implicitHeight | ||
|
|
||
| Column { | ||
| id: addressColumn | ||
| width: parent.width | ||
| spacing: root.expandable && root.expanded ? 6 : 0 | ||
|
|
||
| CoreText { | ||
| id: addressText | ||
| width: parent.width | ||
| text: root.text | ||
| wrap: true | ||
| wrapMode: Text.WordWrap | ||
| horizontalAlignment: root.expandable ? Text.AlignRight : Text.AlignLeft | ||
| verticalAlignment: Text.AlignTop | ||
| height: Math.max(implicitHeight, 32) | ||
| font.pixelSize: 18 | ||
| color: Theme.color.neutral9 | ||
|
|
||
| HoverHandler { | ||
| enabled: root.expandable | ||
| cursorShape: Qt.PointingHandCursor | ||
| } | ||
|
|
||
| TapHandler { | ||
| enabled: root.expandable | ||
| onTapped: root.expanded = !root.expanded | ||
| } | ||
| } | ||
|
|
||
| TextArea { | ||
| id: fullAddressText | ||
| objectName: root.expandedObjectName | ||
| width: parent.width | ||
| visible: root.expandable && root.expanded | ||
| readOnly: true | ||
| text: root.fullText | ||
| wrapMode: Text.WordWrap | ||
| leftPadding: 0 | ||
| topPadding: 0 | ||
| rightPadding: 0 | ||
| bottomPadding: 0 | ||
| height: visible ? Math.max(contentHeight, 32) : 0 | ||
| font.family: "Inter" | ||
| font.styleName: "Regular" | ||
| font.pixelSize: 18 | ||
| color: Theme.color.neutral7 | ||
| background: Item {} | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion: Missing Accessible property for name and role of this component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // Copyright (c) 2026 The Bitcoin Core developers | ||
| // Distributed under the MIT software license, see the accompanying | ||
| // file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
|
||
| import QtQuick 2.15 | ||
| import QtQuick.Controls 2.15 | ||
| import QtQuick.Layouts 1.15 | ||
|
|
||
| import "../controls" | ||
|
|
||
| Item { | ||
| id: root | ||
|
|
||
| property string labelText: qsTr("Amount") | ||
| property string amountText: "" | ||
| property string unitText: "" | ||
| property string text: unitText.length > 0 ? amountText + " " + unitText : amountText | ||
| property int labelWidth: 110 | ||
| property int labelPixelSize: 18 | ||
| property color labelColor: Theme.color.neutral9 | ||
|
|
||
| Layout.fillWidth: true | ||
| implicitHeight: Math.max(label.implicitHeight, amountValue.implicitHeight, unitLabel.implicitHeight) | ||
|
|
||
| CoreText { | ||
| id: label | ||
| width: root.labelWidth | ||
| anchors.left: parent.left | ||
| anchors.verticalCenter: parent.verticalCenter | ||
| horizontalAlignment: Text.AlignLeft | ||
| wrap: false | ||
| text: root.labelText | ||
| font.pixelSize: root.labelPixelSize | ||
| color: root.labelColor | ||
| } | ||
|
|
||
| CoreText { | ||
| id: amountValue | ||
| anchors.left: label.right | ||
| anchors.right: unitLabel.left | ||
| anchors.rightMargin: unitLabel.visible ? 12 : 0 | ||
| anchors.verticalCenter: parent.verticalCenter | ||
| horizontalAlignment: Text.AlignRight | ||
| wrap: false | ||
| elide: Text.ElideRight | ||
| text: root.amountText | ||
| font.pixelSize: 18 | ||
| color: Theme.color.neutral9 | ||
| } | ||
|
|
||
| CoreText { | ||
| id: unitLabel | ||
| anchors.right: parent.right | ||
| anchors.verticalCenter: parent.verticalCenter | ||
| visible: root.unitText.length > 0 | ||
| text: root.unitText | ||
| font.pixelSize: 18 | ||
| color: Theme.color.neutral7 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Missing Accessible property for name and role of this component.