Open
Conversation
johnny9
force-pushed
the
standard-fee-selection
branch
from
d53fbf3 to
46d69b2
Compare
johnny9
force-pushed
the
standard-fee-selection
branch
from
88739f0 to
7824720
Compare
Collaborator
Author
|
Related to #520 |
MarnixCroes
reviewed
Apr 6, 2026
Contributor
MarnixCroes
left a comment
MarnixCroes
left a comment
There was a problem hiding this comment.
build fails 5c7cd51
In file included from /usr/include/x86_64-linux-gnu/qt6/QtTest/qtesteventloop.h:8,
from /usr/include/x86_64-linux-gnu/qt6/QtTest/qsignalspy.h:11,
from /usr/include/x86_64-linux-gnu/qt6/QtTest/QtTest:10,
from /home/marnix/projects/gui-qml/test/test_walletqmlmodel.cpp:5:
/home/marnix/projects/gui-qml/test/test_walletqmlmodel.cpp: In lambda function:
/home/marnix/projects/gui-qml/test/test_walletqmlmodel.cpp:409:9: error: return-statement with no value, in function returning ‘util::Result<std::shared_ptr<const CTransaction> >’ [-fpermissive]
409 | QCOMPARE(recipients.size(), 1U);
| ^~~~~~~~
gmake[2]: *** [test/CMakeFiles/bitcoinqml_unit_tests.dir/build.make:216: test/CMakeFiles/bitcoinqml_unit_tests.dir/test_walletqmlmodel.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:2075: test/CMakeFiles/bitcoinqml_unit_tests.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
5c7cd51 to
a4de80b
Compare
Collaborator
Author
|
fix the compile issue in the unittest |
MarnixCroes
reviewed
Apr 8, 2026
Contributor
MarnixCroes
left a comment
MarnixCroes
left a comment
There was a problem hiding this comment.
some comments from first test (some maybe for follow up):
- Fee amount is not displayed in sats in case this is active
- The Fee Rate entry is not limited when no decimal is used (i.e. it accepts an unlimited amount of characters as long as no comma is used)
- When entering full balance, and not
Include fee in amountthe Review button doesn't work. Which makes sense, but there is no clear user feedback on why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires up fee selection in the Send page. Overrides are in place for Regtest where CoinControl fee estimations aren't supported.