Fix incorrect check in cache_unsigned_tx_pieces#830
Open
bigspider wants to merge 1 commit intobitcoin-core:masterfrom
Open
Fix incorrect check in cache_unsigned_tx_pieces#830bigspider wants to merge 1 commit intobitcoin-core:masterfrom
cache_unsigned_tx_pieces#830bigspider wants to merge 1 commit intobitcoin-core:masterfrom
Conversation
`self.tx is not None` is always true because the constructor sets `self.tx = CTransaction()` when `None` is passed, which causes a call to `setup_from_tx` also for PSBT version 2, contrarily to the function's stated intent in the documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self.tx is not Noneis always true because the constructor setsself.tx = CTransaction()whenNoneis passed, which causes a call tosetup_from_txalso for PSBT version 2, contrarily to the function's stated intent in the documentation.