Add a cargo_criterion_support feature flag#541
Open
str4d wants to merge 1 commit intobheisler:version-0.4from
Open
Add a cargo_criterion_support feature flag#541str4d wants to merge 1 commit intobheisler:version-0.4from
cargo_criterion_support feature flag#541str4d wants to merge 1 commit intobheisler:version-0.4from
Conversation
This enables `cargo-criterion` support to be compiled out if it is not required. A compile-time error is added to require that at least one of [`cargo_bench_support`, `cargo_criterion_support`] must be enabled.
Merged
str4d
commented
Dec 27, 2021
Comment on lines
+135
to
138
| #[cfg(feature = "cargo_criterion_support")] | ||
| lazy_static! { | ||
| static ref CARGO_CRITERION_CONNECTION: Option<Mutex<Connection>> = { | ||
| match std::env::var("CARGO_CRITERION_PORT") { |
Author
There was a problem hiding this comment.
Currently, when cargo_criterion_support is not enabled, criterion behaves as if cargo-criterion does not exist. It might be useful to check somewhere whether the CARGO_CRITERION_PORT env variable is set, and print a warning or error if cargo_criterion_support is not enabled. This wouldn't be the right place; it would need to go in the benchmark's main function (similar to the previous warnings when cargo_bench_support was not enabled).
Collaborator
|
I'm not sure what we should do about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables
cargo-criterionsupport to be compiled out if it is not required. A compile-time error is added to require that at least one of [cargo_bench_support,cargo_criterion_support] must be enabled.