Skip to content

make sure the buff can be written - #1057

Open
ccqy66 wants to merge 1 commit into
bfenetworks:developfrom
ccqy66:dev_buffer
Open

make sure the buff can be written#1057
ccqy66 wants to merge 1 commit into
bfenetworks:developfrom
ccqy66:dev_buffer

Conversation

@ccqy66

@ccqy66 ccqy66 commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

at the same time, I think the following codes don't make sense:

if (b.w + n) > len(b.buf) {
	log.Logger.Warn("bfe_bufio:reader.fill(),len(buf)=%d,b.r=%d,b.w=%d,n=%d\n",
			len(b.buf), b.r, b.w, n
}

theoretically, b.w+n <= len(b.buf). when b.w+n can be > len(b.buf)?

Signed-off-by: chenchen.ccqy66 <chenchen.ccqy66@bytedance.com>
@codecov-commenter

codecov-commenter commented Jun 24, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.21%. Comparing base (1c59d17) to head (123a997).
⚠️ Report is 124 commits behind head on develop.

Files with missing lines Patch % Lines
bfe_bufio/bufio.go 0.00% 1 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1057      +/-   ##
===========================================
- Coverage    54.23%   54.21%   -0.02%     
===========================================
  Files          301      301              
  Lines        26604    26606       +2     
===========================================
- Hits         14429    14425       -4     
- Misses       10509    10513       +4     
- Partials      1666     1668       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


chenchen.ccqy66 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants