Add late days column for extensions#392
Open
noahnizamian wants to merge 4 commits intoberkeley-cdss:mainfrom
Open
Add late days column for extensions#392noahnizamian wants to merge 4 commits intoberkeley-cdss:mainfrom
noahnizamian wants to merge 4 commits intoberkeley-cdss:mainfrom
Conversation
Mass approve/ reject functionality and UI changes for request table PR reviewed and merged into Golden Repo. Thank you!
|
✅ @noahnizamian — Superconductor finished — View implementation | App Preview Standing by for instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Info
original CDSS issue: #291
Changes
Adds an "approved days" column to the course enrollments page, where you can see the total number of late days each student has had approved from extension requests. it does not count rejected extensions, and if the student approved more than one request on the same assignment, it counts only the widest one. also the column is blank for staff roles
Testing
I added RSpec tests in spec/models/request_spec.rb for .total_approved_late_days_by_user which
Also added controller spec in spec/controllers/courses_controller_spec.rb to verify that @approved_late_days is assigned
Documentation
No documentation needed
Checklist