Updated AtomExtensions to create XmlSyndicationContent when ContentType is set to "xml" #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe is set to "xml". Changed IPublication.Content to object to support arbitrary object type. Object is XmlSerialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing the changes I had to make to support my use case: having content type="text/xml" in feed entry content. Current code supports only plain text and html. I updated AtomExtensions to create XmlSyndicationContent when ContentType is set to "xml". Just sharing my changes - I'm not requesting a merge in right now as the changes were made only on the feed generation side and not for create/update operations. Also, made a breaking change - IPublication.Content changed from string to object which could be handled more elegantly.