Add Chart component to GroupTable #702
Conversation
|
|
||
| interface GroupTableChartProps { | ||
| dataSource: RepeatableGroupTableRow[]; | ||
| linkIdX: string | undefined; |
There was a problem hiding this comment.
There is no sense to pass empty linkIdX and linkIdY.
This case should be handles in the parent component.
| } | ||
| return { | ||
| name: item.key, | ||
| x: item[linkIdX]?.formItem?.[0]?.value?.date, |
There was a problem hiding this comment.
It may be dateTime or even Intger. Please handle this edge cases
There was a problem hiding this comment.
refactored to abstract value getter
| axisLine={false} | ||
| /> | ||
| <CartesianGrid /> | ||
| {/*<CartesianAxis display={'none'} />*/} |
| import { RepeatableGroupTableRow } from './types'; | ||
|
|
||
| const getEnableChartExtension = compileAsFirst<QuestionnaireItem, Extension>( | ||
| `extension.where(url='https://emr-core.beda.software/StructureDefinition/enableChart')`, |
There was a problem hiding this comment.
Extensions should be defined here https://github.com/beda-software/beda-emr-core
| snapshotDataSource, | ||
| renderAsTable, | ||
| handleRenderTypeToggle, | ||
| enabledChart: !!extensionEnableChart, |
There was a problem hiding this comment.
This flag is not needed.
Use handleRenderTypeToggle as a flag if it is not defined it is just a Table
There was a problem hiding this comment.
refactored approach
| import { RepeatableGroupTableRow } from './types'; | ||
|
|
||
| const getEnableChartExtension = compileAsFirst<QuestionnaireItem, Extension>( | ||
| `extension.where(url='https://emr-core.beda.software/StructureDefinition/enable-chart')`, |
There was a problem hiding this comment.
@alexlipovka use extension function instead of where
There was a problem hiding this comment.
Not relevant, now data comes from first class extension fields
| }); | ||
|
|
||
| return ( | ||
| <ResponsiveContainer width="100%" height={'100%'}> |
There was a problem hiding this comment.
<ResponsiveContainer width="100%" height="100%">
| /> | ||
| </S.Item> | ||
| )} | ||
| {repeats && |
There was a problem hiding this comment.
Show error if props are incorrect.
repeats is false or one of (both) chartLinkIdX,chartLinkIdY is not defined.
Provide user friendly error message.
| return Array.isArray(item) && item.every((item) => item !== undefined && item !== null && 'value' in item); | ||
| }; | ||
|
|
||
| const getValueFromAnswerValue = (answerValue: AnswerValue, questionnaireItemType: QuestionnaireItem['type']) => { |
There was a problem hiding this comment.
Wasn't it define under GroupTable pull request?
If it is a refactoring I don't see getValueFromAnswerValue removed from another file
There was a problem hiding this comment.
Not quite, there we defined readonly rendering, but here we only need raw values
There was a problem hiding this comment.
refactored to use common functions
2 participants
Ref: