feat(appservice): support new format olaresmanifest multi chip resources#2947
Merged
feat(appservice): support new format olaresmanifest multi chip resources#2947
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b629baa. Configure here.
eball
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

feat: support new format olaresmanifest multi chip resources
v1.12.6,v1.12.7
None
None
Note
Medium Risk
Changes install/upgrade decisioning and resource requirement resolution based on new manifest versions, which can affect scheduling/permissions and whether server components are deployed for v2 apps.
Overview
Adds support for a new
OlaresManifestformat that describes per-chip/per-mode resource requirements and v2 client vs client+server overlays, and applies these overlays during install/upgrade to compute the effective config andRequirement.Install/upgrade now determines an
installType/upgradeType(including a v2 check for existing shared namespaces) and updates Helm values to exposeclient/clientAndServerflags (with upgrade/admin special-casing). Manifest parsing is updated to detect manifest version, readapiVersionwithout templating, and populate newspec.resources/overlay fields; GPU types addmthreads-m1000, and the app-service image is bumped to0.5.16.Reviewed by Cursor Bugbot for commit b629baa. Bugbot is set up for automated code reviews on this repo. Configure here.