Skip to content

feat(appservice): support new format olaresmanifest multi chip resources#2947

Merged
eball merged 10 commits intomainfrom
module-appservice
Apr 24, 2026
Merged

feat(appservice): support new format olaresmanifest multi chip resources#2947
eball merged 10 commits intomainfrom
module-appservice

Conversation

@hysyeah
Copy link
Copy Markdown
Member

@hysyeah hysyeah commented Apr 24, 2026

  • Background
    feat: support new format olaresmanifest multi chip resources
  • Target Version for Merge
    v1.12.6,v1.12.7
  • Related Issues
    None
  • PRs Involving Sub-Systems
    None

Note

Medium Risk
Changes install/upgrade decisioning and resource requirement resolution based on new manifest versions, which can affect scheduling/permissions and whether server components are deployed for v2 apps.

Overview
Adds support for a new OlaresManifest format that describes per-chip/per-mode resource requirements and v2 client vs client+server overlays, and applies these overlays during install/upgrade to compute the effective config and Requirement.

Install/upgrade now determines an installType/upgradeType (including a v2 check for existing shared namespaces) and updates Helm values to expose client/clientAndServer flags (with upgrade/admin special-casing). Manifest parsing is updated to detect manifest version, read apiVersion without templating, and populate new spec.resources/overlay fields; GPU types add mthreads-m1000, and the app-service image is bumped to 0.5.16.

Reviewed by Cursor Bugbot for commit b629baa. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
olares-docs Ignored Ignored Preview Apr 24, 2026 1:54pm

Request Review

Comment thread framework/app-service/pkg/apiserver/handler_installer_upgrade.go
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b629baa. Configure here.

Comment thread framework/app-service/pkg/apiserver/handler_installer_install.go
Comment thread framework/app-service/pkg/apiserver/handler_installer_install.go
@eball eball merged commit cce3b29 into main Apr 24, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants