Conversation
Contributor
|
Global ticket amount is inconsistent with a discount on only one product type. |
gntw
force-pushed
the
fix/pos_discount_on_tag_applies_on_whole_pool__2391
branch
2 times, most recently
from
9130e6e to
2a0a36f
Compare
roosemberth
suggested changes
Feb 13, 2026
src/routes/(app)/pos/touch/tab/[orderTabSlug]/split/+page.server.ts
Outdated
Show resolved
Hide resolved
src/routes/(app)/pos/touch/tab/[orderTabSlug]/ticket/+page.server.ts
Outdated
Show resolved
Hide resolved
gntw
force-pushed
the
fix/pos_discount_on_tag_applies_on_whole_pool__2391
branch
2 times, most recently
from
5520c96 to
ec453c4
Compare
Contributor
|
Fix seems functional ✅ Were change request applied previously ? |
Tirodem
force-pushed
the
fix/pos_discount_on_tag_applies_on_whole_pool__2391
branch
from
ec453c4 to
4393708
Compare
Tirodem
approved these changes
Feb 26, 2026
Tirodem
approved these changes
Feb 26, 2026
Tirodem
approved these changes
Feb 26, 2026
Contributor
|
@roosemberth I cannot validate requested changes, will you have the time to confirm them ? Otherwise I'll bypass tomorrow. Thanks. |
- Set per-item discountPercentage by tag match in getHydratedOrderTab - Replace blind total * (1 - percentage/100) with tag-aware calculation - Group Global Ticket items by discount tag with per-group breakdown - Use effective multiplier (total/totalBeforeDiscount) on printed ticket Fixes issue #2391
gntw
force-pushed
the
fix/pos_discount_on_tag_applies_on_whole_pool__2391
branch
from
4393708 to
5ea2027
Compare
Tirodem
deleted the
fix/pos_discount_on_tag_applies_on_whole_pool__2391
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POS discount with a tag filter (e.g. 100% off "Alcohol") was incorrectly applied to the entire pool total in the split page and Global Ticket. Now only matching items are discounted; other items remain at full price.
Closes #2391