Skip to content

🦋🤖 Forward receipt to customer from order page (#2375)#2377

Merged
Tirodem merged 1 commit intomainfrom
feat/forward-receipt-2375
Feb 27, 2026
Merged

🦋🤖 Forward receipt to customer from order page (#2375)#2377
Tirodem merged 1 commit intomainfrom
feat/forward-receipt-2375

Conversation

@Tirodem
Copy link
Contributor

@Tirodem Tirodem commented Feb 5, 2026

  • Employees can now forward a receipt to a customer directly from the order page
  • Available on paid orders only, for both classic POS and POS Touch
  • Supports sending via email (sends the order.paid email) or Nostr DM (sends ticket content + order link)
  • Inline form with contact address input (email or Nostr npub), same pattern as the RSVP form
  • Success confirmation displayed after forwarding

@Tirodem Tirodem changed the title 🦋 Forward receipt to customer from order page (#2375) 🦋🤖 Forward receipt to customer from order page (#2375) Feb 5, 2026
@Tirodem Tirodem requested review from gntw and roosemberth February 5, 2026 20:25
@Tirodem
Copy link
Contributor Author

Tirodem commented Feb 5, 2026

@gntw @roosemberth Either vibefix or vibeprototype, depending of your's review feedbacks. Pilot's request. QA is OK ✅

@gntw gntw self-assigned this Feb 12, 2026
@gntw
Copy link
Contributor

gntw commented Feb 13, 2026

@Tirodem got a questsion about the Nostr DM content in forwardReceipt: currently the DM sent to the customer only contains a link — Order #N receipt: . The original issue description mentions "the customer receives a DM with the ticket content and order link". Is this intentional to keep it minimal (just the link), or should we include more order details in the DM (items, total amount, payment method etc.)?

@Tirodem
Copy link
Contributor Author

Tirodem commented Feb 13, 2026 via email

@gntw gntw force-pushed the feat/forward-receipt-2375 branch from e7f2284 to 69366e7 Compare February 13, 2026 10:50
@roosemberth roosemberth force-pushed the feat/forward-receipt-2375 branch from 69366e7 to 6136da9 Compare February 19, 2026 12:35
@Tirodem
Copy link
Contributor Author

Tirodem commented Feb 23, 2026

Filling partial npub =
image
Otherwise, a valid npub is OK, a valid email is OK ✅
It's clearly acceptable, but if it can be done in front, with error message + highlighted input field, it would be great
BTW, it can be another ticket, as it's currently not done in /schedule/{id_schedule}/rsvp/{schedule_event}?/notify.
So :
@gntw , if you're OK with @roosemberth , we can merge like this
@CypherJack , can you create the new ticket to improve this input please

@roosemberth roosemberth force-pushed the feat/forward-receipt-2375 branch from 6136da9 to f3fb5aa Compare February 24, 2026 14:09
Copy link
Contributor

@roosemberth roosemberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of introducing behaviour in “Various code grooming” commits:

  • The refactor and added permission check in this change is a band-aid.
  • We hid new behavior in a “grooming” commit, if we find this behaviour to be faulty, it will waste people's time to figure out the extent of the problem.

Please move this to a separate commit.

@gntw
Copy link
Contributor

gntw commented Feb 27, 2026

I'm not a fan of introducing behaviour in “Various code grooming” commits:

  • The refactor and added permission check in this change is a band-aid.
  • We hid new behavior in a “grooming” commit, if we find this behaviour to be faulty, it will waste people's time to figure out the extent of the problem.

Please move this to a separate commit.

If we are going to merge all of this, then we probably wanted to squash it into one commit, as we do it in most of our pull requests? There are currently five commits in the branch, and I don't see much point in keeping them separate. I agree, the topic of my commit is ridiculous, but I thought that after the review I would squash all these commits into one so as not to clutter up the main branch. And then I could write a normal description for this single commit.

@roosemberth is that ok ?

@gntw gntw force-pushed the feat/forward-receipt-2375 branch 2 times, most recently from 94a30c7 to 26bba52 Compare February 27, 2026 12:40
Add a "Forward receipt" CTA on paid order pages (staff only).
On click, an inline form allows entering an email or Nostr npub.
- Email: sends the order.paid email template
- Nostr npub: sends a DM with ticket content and order link
Confirmation feedback displayed after forwarding.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@Tirodem Tirodem force-pushed the feat/forward-receipt-2375 branch from 26bba52 to 1b6c7e3 Compare February 27, 2026 16:26
@Tirodem Tirodem merged commit 55b57ea into main Feb 27, 2026
6 checks passed
@Tirodem Tirodem deleted the feat/forward-receipt-2375 branch February 27, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants