Skip to content

[SW-4178] Spot calibration params bug#189

Merged
tcappellari-bdai merged 5 commits intomainfrom
tcapp/calibration_bug
Jan 22, 2026
Merged

[SW-4178] Spot calibration params bug#189
tcappellari-bdai merged 5 commits intomainfrom
tcapp/calibration_bug

Conversation

@tcappellari-bdai
Copy link
Collaborator

the values sent to Spot to override its default calibration for the depth and rbg cameras was incorrect

@coveralls
Copy link

coveralls commented Dec 19, 2025

Pull Request Test Coverage Report for Build 21255993028

Details

  • 0 of 27 (0.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 44.236%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spot_wrapper/calibration/spot_in_hand_camera_calibration.py 0 27 0.0%
Files with Coverage Reduction New Missed Lines %
spot_wrapper/calibration/spot_in_hand_camera_calibration.py 3 0.0%
Totals Coverage Status
Change from base Build 21070616337: -0.05%
Covered Lines: 2195
Relevant Lines: 4962

💛 - Coveralls

@tcappellari-bdai tcappellari-bdai marked this pull request as ready for review January 22, 2026 16:20
Copy link
Collaborator

@khughes-bdai khughes-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might be good to check this with @lgalup-bdai since i know he's been trying to debug calibration issues lately too

@tcappellari-bdai tcappellari-bdai merged commit 391a68c into main Jan 22, 2026
4 checks passed
@tcappellari-bdai tcappellari-bdai deleted the tcapp/calibration_bug branch January 22, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants