fix(deps): regenerate backend package-lock.json to sync with overrides#2651
fix(deps): regenerate backend package-lock.json to sync with overrides#2651DerekRoberts merged 2 commits intomainfrom
Conversation
PR #2646 lock file maintenance updated hono to 4.12.9 in the lock file, but the overrides in package.json pinned hono@<4.11.7 to 4.11.7, causing npm ci to fail with a version mismatch. Regenerating the lock file resolves the inconsistency.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- backend/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
backend/package-lock.json, but theoverridessection inbackend/package-lock.jsonpinshono@<4.11.7to4.11.7. This causednpm cito fail with:Invalid: lock file's hono@4.12.9 does not satisfy hono@4.11.7.npm install --package-lock-onlyto resolve the inconsistency.npm ci,npm run build, andnpm run lintall pass.Root Cause: How #2646 Merged Despite Failing
The repository ruleset (configured via GitHub Rulesets, not branch protection) requires these status checks:
Analysis Results(from Analysis workflow)PR Results(from PR workflow)Validate Results(from PR Validate workflow)The
Backend Testsjob (which runsnpm ci) failed, but becauseAnalysis Resultshasneeds: [backend-tests, frontend-tests]and theresultsjob only fails whenneeds.*.resultcontainsfailureorcanceled— however, the backend-tests was not skipped, it failed. The actual issue is that theanalysis-resultscheck name registered as SKIPPED (passing) while the individualBackend Testscheck registered as FAILURE. Since onlyAnalysis Resultsis in the required checks list (notBackend Tests), the PR was allowed to merge.Additionally, the
Builds (backend)check (from the PR workflow) passed because it builds inside a Docker container usingdeployscript (npm ci --ignore-scripts) which runs at a different layer, not the hostnpm ciused by the Analysis workflow.Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: