Skip to content

fix(deps): regenerate backend package-lock.json to sync with overrides#2651

Merged
DerekRoberts merged 2 commits intomainfrom
fix/backend-lock-file-sync
Apr 1, 2026
Merged

fix(deps): regenerate backend package-lock.json to sync with overrides#2651
DerekRoberts merged 2 commits intomainfrom
fix/backend-lock-file-sync

Conversation

@DerekRoberts
Copy link
Copy Markdown
Member

@DerekRoberts DerekRoberts commented Apr 1, 2026

Summary

  • PR chore(deps): lock file maintenance #2646 (renovate lock file maintenance) updated hono to 4.12.9 in backend/package-lock.json, but the overrides section in backend/package-lock.json pins hono@<4.11.7 to 4.11.7. This caused npm ci to fail with: Invalid: lock file's hono@4.12.9 does not satisfy hono@4.11.7.
  • Regenerated the lock file via npm install --package-lock-only to resolve the inconsistency.
  • Verified: npm ci, npm run build, and npm run lint all pass.

Root Cause: How #2646 Merged Despite Failing

The repository ruleset (configured via GitHub Rulesets, not branch protection) requires these status checks:

  1. Analysis Results (from Analysis workflow)
  2. PR Results (from PR workflow)
  3. Validate Results (from PR Validate workflow)

The Backend Tests job (which runs npm ci) failed, but because Analysis Results has needs: [backend-tests, frontend-tests] and the results job only fails when needs.*.result contains failure or canceled — however, the backend-tests was not skipped, it failed. The actual issue is that the analysis-results check name registered as SKIPPED (passing) while the individual Backend Tests check registered as FAILURE. Since only Analysis Results is in the required checks list (not Backend Tests), the PR was allowed to merge.

Additionally, the Builds (backend) check (from the PR workflow) passed because it builds inside a Docker container using deploy script (npm ci --ignore-scripts) which runs at a different layer, not the host npm ci used by the Analysis workflow.


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

PR #2646 lock file maintenance updated hono to 4.12.9 in the lock file,
but the overrides in package.json pinned hono@<4.11.7 to 4.11.7, causing
npm ci to fail with a version mismatch. Regenerating the lock file resolves
the inconsistency.
Copilot AI review requested due to automatic review settings April 1, 2026 02:50
@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 1, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: frontend/package-lock.jsonnpm/jsdom@29.0.1npm/entities@6.0.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@6.0.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • backend/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@DerekRoberts DerekRoberts self-assigned this Apr 1, 2026
@DerekRoberts DerekRoberts merged commit d102648 into main Apr 1, 2026
34 of 36 checks passed
@DerekRoberts DerekRoberts deleted the fix/backend-lock-file-sync branch April 1, 2026 03:50
@github-project-automation github-project-automation bot moved this from New to Done in DevOps (NR) Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants