Skip to content

Displaying deployments in an overview table#1572

Draft
AMEIJER1 wants to merge 5 commits into
devfrom
deployments-overview
Draft

Displaying deployments in an overview table#1572
AMEIJER1 wants to merge 5 commits into
devfrom
deployments-overview

Conversation

@AMEIJER1
Copy link
Copy Markdown
Collaborator

@AMEIJER1 AMEIJER1 commented Aug 12, 2025

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • Added deployments tab to the tabular data overview

Testing Notes

  • Animals are not rendering in the animals overview table, and the mapping from critterbase critter id to animal alias are not working. unsure if this is a critterbase issue, it seems to not be returning data requested underneath any critterbase critter ids
  • this also means we can't test the filtering on the alias' right now, or species
  • future techdebt once collections is into dev and projects disappear out of the urls, we will make the surveyid columns into links
  • NOTE: do we like the way the table is displayed as a tab beside the other data types, or should it be nested inside telemetry?

@AMEIJER1 AMEIJER1 requested a review from mauberti-bc August 12, 2025 00:22
@AMEIJER1 AMEIJER1 self-assigned this Aug 12, 2025
@AMEIJER1 AMEIJER1 added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Aug 12, 2025
@github-actions
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
8.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 0% with 413 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.86%. Comparing base (21118f7) to head (ee344ea).
⚠️ Report is 43 commits behind head on dev.

Files with missing lines Patch % Lines
...bular-data/deployments/DeploymentListContainer.tsx 0.00% 237 Missing ⚠️
...ular-data/deployments/DeploymentListFilterForm.tsx 0.00% 67 Missing ⚠️
...telemetry/list/SurveyDeploymentListItemDetails.tsx 0.00% 47 Missing ⚠️
api/src/paths/deployment/index.ts 0.00% 23 Missing ⚠️
app/src/hooks/api/useTelemetryDeploymentApi.ts 0.00% 16 Missing ⚠️
...ry-repositories/telemetry-deployment-repository.ts 0.00% 14 Missing ⚠️
...summary/tabular-data/TabularDataTableContainer.tsx 0.00% 5 Missing ⚠️
.../deployments/form/timeline/DeploymentStartForm.tsx 0.00% 2 Missing ⚠️
api/src/repositories/survey-critter-repository.ts 0.00% 1 Missing ⚠️
...try/manage/deployments/edit/EditDeploymentPage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1572      +/-   ##
==========================================
- Coverage   33.07%   32.86%   -0.21%     
==========================================
  Files        1033     1036       +3     
  Lines       65168    65578     +410     
  Branches     2357     2368      +11     
==========================================
  Hits        21553    21553              
- Misses      43075    43485     +410     
  Partials      540      540              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dylanrogowsky-oxd dylanrogowsky-oxd force-pushed the dev branch 4 times, most recently from 9d98b27 to ca95d07 Compare September 18, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Early Feedback Welcome PR is not finished, but early review feedback is welcomed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant