Skip to content

Adding inactive or active tabs to devices container#1570

Draft
AMEIJER1 wants to merge 17 commits into
collectionsfrom
collections-devices
Draft

Adding inactive or active tabs to devices container#1570
AMEIJER1 wants to merge 17 commits into
collectionsfrom
collections-devices

Conversation

@AMEIJER1
Copy link
Copy Markdown
Collaborator

@AMEIJER1 AMEIJER1 commented Aug 6, 2025

Description of Changes

  • modifying devices container to create helper functions determining whether devices are currently engaged in deployments
  • removing the "deployed on" animal column from the devices table

Testing Notes

  • no data overlay is formatted the same in devicescontainer as it is in deployments container, but deployments container has the grey that stretches to the bottom of the paper on the survey tabs page, whereas devices does not stretch to the bottom on the survey view of the devices table. cannot figure out how to extend this. Also, modifying height seems to not be the solution since on the telemetry/manage page we need to have some min heights for those tables so that the tables aren't totally collapsed if they have no data.

@AMEIJER1 AMEIJER1 self-assigned this Aug 6, 2025
@AMEIJER1 AMEIJER1 added Early Feedback Welcome PR is not finished, but early review feedback is welcomed Not Ready For Review Addressing feedback and/or refactoring labels Aug 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 6, 2025

Comment thread .vscode/tasks.json Outdated
@AMEIJER1 AMEIJER1 added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed Not Ready For Review Addressing feedback and/or refactoring labels Aug 6, 2025
@LouisThedroux LouisThedroux self-requested a review August 12, 2025 19:44
@LouisThedroux LouisThedroux self-assigned this Aug 12, 2025
Copy link
Copy Markdown
Contributor

@LouisThedroux LouisThedroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have gone over this and made a bunch of changes. It is working as it should now with some tweaks to styling etc.

Comment thread .gitignore
@LouisThedroux LouisThedroux self-requested a review August 13, 2025 23:40
@LouisThedroux
Copy link
Copy Markdown
Contributor

Code duplication failed. Will go over it again and try to refine where possible.

@LouisThedroux LouisThedroux requested a review from Copilot August 14, 2025 16:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the telemetry devices management interface to distinguish between active and inactive devices based on their deployment status. It replaces bulk actions and device deletion functionality with a toggle system that filters devices by their deployment state.

  • Removes bulk selection, deletion, and import functionality from devices management
  • Adds active/inactive device filtering with toggle buttons based on deployment status
  • Removes the "Deployed On" animal column from the devices table and replaces action menu options

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
DevicesTable.tsx Removes device deletion, bulk selection, and "Deployed On" column; simplifies menu actions
DevicesContainer.tsx Adds active/inactive device filtering with toggle buttons and helper functions for deployment status
SurveyDeploymentListItem.tsx Removes checkbox selection functionality from deployment list items
SurveyDeploymentList.tsx Removes bulk actions and deletion functionality from deployment list
SurveySpatialTelemetry.tsx Updates import statement and navigation routing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment thread app/src/features/surveys/telemetry/manage/devices/table/DevicesContainer.tsx Outdated
Comment thread app/src/features/surveys/telemetry/list/SurveyDeploymentList.tsx Outdated
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@LouisThedroux LouisThedroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gone over and changed a few things but is working and looks better now.

@LouisThedroux LouisThedroux self-requested a review August 26, 2025 18:29
@LouisThedroux LouisThedroux added the Do Not Merge PR should not be merged label Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge PR should not be merged Ready For Review PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants