Skip to content

Adding sample site period / visit comment capability and ARU sampling method#1568

Draft
AMEIJER1 wants to merge 6 commits into
devfrom
visit_comment
Draft

Adding sample site period / visit comment capability and ARU sampling method#1568
AMEIJER1 wants to merge 6 commits into
devfrom
visit_comment

Conversation

@AMEIJER1
Copy link
Copy Markdown
Collaborator

@AMEIJER1 AMEIJER1 commented Jul 24, 2025

Description of Changes

  • adding ARU as a sampling method
  • Adding comments to sampling_period_visit
  • changing create sampling period page to allow for submission of comments
  • configured bulk upload capability to include comments

Testing Notes

  • handlesubmit on my createsampleperiodpage is using a for loop to submit one period at a time. should we update the page and index file so that it pushes them all up at one instead of iterating?

@AMEIJER1 AMEIJER1 requested a review from mauberti-bc July 24, 2025 21:16
@AMEIJER1 AMEIJER1 self-assigned this Jul 24, 2025
@AMEIJER1 AMEIJER1 added the Not Ready For Review Addressing feedback and/or refactoring label Jul 24, 2025
@github-actions
Copy link
Copy Markdown

@AMEIJER1 AMEIJER1 added Ready For Review PR is ready for review and removed Not Ready For Review Addressing feedback and/or refactoring labels Jul 28, 2025
--------------------------------------------------------------------------------------------------

ALTER TABLE survey_sample_period
ADD COLUMN comment TEXT;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to limit the length of comment columns, so instead of TEXT you can do something like VARCHAR(1000).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done (Y)

@LouisThedroux
Copy link
Copy Markdown
Contributor

@AMEIJER1

So now we have a comment column on display in the sampling period table on the manage sampling information page. However, I dont see anyway of adding a comment to an existing or new sampling period. Is this something I am missing, or does it need to be added? I guess it can still be added via importing a csv with a comment column? Do we need a way to add manual comments when directly adding or editing comments in the UI?

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@AMEIJER1
Copy link
Copy Markdown
Collaborator Author

AMEIJER1 commented Aug 27, 2025

@AMEIJER1

So now we have a comment column on display in the sampling period table on the manage sampling information page. However, I dont see anyway of adding a comment to an existing or new sampling period. Is this something I am missing, or does it need to be added? I guess it can still be added via importing a csv with a comment column? Do we need a way to add manual comments when directly adding or editing comments in the UI?

Hi!! Thanks for reviewing it - I just built web and was able to edit the existing sampling period seed data in the UI by editing the sampling period through that vertical ellipses on the sampling period table beside each record. It will pull up the create sampling period form in which they can add a comment. @LouisThedroux

@dylanrogowsky-oxd dylanrogowsky-oxd force-pushed the dev branch 4 times, most recently from 9d98b27 to ca95d07 Compare September 18, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready For Review PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants