Collections users drew#1554
Draft
LouisThedroux wants to merge 49 commits into
Draft
Conversation
…I cll as this goes out to same port the app is on by default 7100 and not 6100
…p. Ensured is an array to fix
LouisThedroux
added
Early Feedback Welcome
|
Openshift URLs for the PR Deployment: |
AMEIJER1
approved these changes
Jun 4, 2025
Collaborator
|
Should this be merged into the collections branch or collections-users? |
Contributor
Author
collection-users. This was a branch I made to help Annika on the collection-users branch, which would then be pulled into collections. |
mauberti-bc
reviewed
Jun 19, 2025
| } | ||
| }, | ||
| responses: { | ||
| 200: { |
Collaborator
There was a problem hiding this comment.
This implies that there is no response body for status 200, but your return (res.status(200).json(...) is indeed sending a response body.
mauberti-bc
reviewed
Jun 19, 2025
| const surveyMemberService = new SurveyMemberService(connection); | ||
| await surveyMemberService.postSurveyMembers(surveyId, members); | ||
| await connection.commit(); | ||
| return res.status(200).json({ message: 'Members added successfully' }); |
Collaborator
There was a problem hiding this comment.
Replace .json(...) with .send()
mauberti-bc
reviewed
Aug 11, 2025
mauberti-bc
reviewed
Aug 11, 2025
mauberti-bc
reviewed
Aug 11, 2025
mauberti-bc
reviewed
Aug 11, 2025
mauberti-bc
reviewed
Aug 11, 2025
mauberti-bc
reviewed
Aug 11, 2025
Collaborator
|
Also make sure to check the sonarcloud issues when reviewing PRs |
LouisThedroux
added
Do Not Merge
mauberti-bc
reviewed
Sep 15, 2025
|
LouisThedroux
added
Ready For Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The purpose of the branch was to enable adding bulk members to collections.
This pull request was originally created as a quick fix for Annika to address critical survey page rendering issues in the
collections-usersbranch. The primary intention was to resolve immediate problems, not to serve as a long-term solution or main development branch. However, as fixes accumulated, this branch was adopted as the main workstream for related survey and member management improvements. The branch will now be merged intocollections, superseding its original purpose.Summary of Original Changes (June 4, 2025)
Created an invite survey members page that calls forms to handle selecting surveys and members
Added POST Endpoint for Adding Members
Introduced a dedicated endpoint to add survey members in bulk to more than one survey
Validation Update – Members and surveys Required
Enforced “members” and "surveys" as required fields to resolve validation errors
Standalone Member Addition Logic ??
Refactored member addition so it no longer relies solely on a fetch method within the API call. This now targets the correct port (
7100for app, not6100), improving reliability and avoiding cross-port issues.Next Steps