Fixes rust-analyzer include_dirs for crates with generated sources - #3840
Merged
Conversation
Contributor
Author
|
@UebelAndre is there someone that can take a look at this? |
Contributor
Author
|
@UebelAndre fyi this is a simple change building on #3836. I've just rebased it so it should be mergable. |
Contributor
Author
|
I've rebased this change so it can be cleanly merged. |
Contributor
Author
|
@UebelAndre this is up to date again if there's someone who can take a look. |
UebelAndre
approved these changes
Jun 10, 2026
UebelAndre
left a comment
UebelAndre
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! And sorry for the delay!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a crate contains generated sources,
include_dirsneeds to include BOTH the root_module directory, and the generated sources directory.When
include_dirsis empty, the inclusion of the root_module directory is done automatically, but when settinginclude_dirs, this needs to be done manually.See:
https://github.com/rust-lang/rust-analyzer/blob/a84d92ff213e30fb00d7b812e07c4f67e99dcd29/crates/project-model/src/project_json.rs#L123-L131