Execution: migrate BlazeQueryDirectoryToTargetProvider to BazelExecService#8283
Open
LeFrosch wants to merge 2 commits intobazelbuild:masterfrom
Open
Execution: migrate BlazeQueryDirectoryToTargetProvider to BazelExecService#8283LeFrosch wants to merge 2 commits intobazelbuild:masterfrom
LeFrosch wants to merge 2 commits intobazelbuild:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the BlazeQueryDirectoryToTargetProvider to use BazelExecService for executing Blaze queries, replacing the older BuildSystem and BuildInvoker mechanism. This involves updating imports and the runQuery method's implementation, including its exception handling. The feedback suggests an improvement to the runQuery method by flattening a nested try-with-resources statement to enhance readability and reduce indentation.
base/src/com/google/idea/blaze/base/dependencies/BlazeQueryDirectoryToTargetProvider.java
Show resolved
Hide resolved
github-actions
bot
added
product: CLion
LeFrosch
force-pushed
the
pull/249fc7c8f8a1e987dab6746b30a3b6998f27fcb5
branch
from
b3b00c8 to
7614441
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the consolidation effort of the Bazel invocations.