Workspace: add arm toolchain test#8279
Conversation
# Conflicts: # clwb/tests/headlesstests/com/google/idea/blaze/clwb/ExecutionTest.kt # testing/src/com/google/idea/testing/headless/HeadlessTestCase.java # Conflicts: # MODULE.bazel.lock
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for ARM toolchains and platform_transition_binary by updating the IntelliJ aspect and adding a dedicated headless test. It also refactors BazelVersionRule to support version ranges and adds helper methods for version comparison. Review feedback correctly identifies a logic error in the isAtMost implementation and an unused import in the new test class.
| .compare(this.major, major) | ||
| .compare(this.minor, minor) | ||
| .compare(this.bugfix, bugfix) | ||
| .result() < 0; |
There was a problem hiding this comment.
The isAtMost method is implemented incorrectly. It should return true if the current version is less than or equal to the provided version. The current implementation with result() < 0 only checks for "less than", which means it will incorrectly return false when the versions are equal. The check should be result() <= 0.
| .result() < 0; | |
| .result() <= 0; |
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
This import is unused and can be removed to keep the code clean.
github-actions
bot
added
product: CLion
github-project-automation
bot
moved this from Untriaged
to Done
in Bazel IntelliJ Plugin
github-actions
bot
removed
the
awaiting-review
4 participants
Adds an integration test for configuration transitions using the arm toolchain.