Add experimental option to generate dependencies labels against an external repository#51
Open
hborawski wants to merge 4 commits intobazel-ios:masterfrom
Open
Add experimental option to generate dependencies labels against an external repository#51hborawski wants to merge 4 commits intobazel-ios:masterfrom
hborawski wants to merge 4 commits intobazel-ios:masterfrom
Conversation
Author
|
Build seems to have failed |
Collaborator
|
@hborawski Thanks for the PR! GitHub upgraded the Mac hosts for running actions, Xcode 12.2 is not valid any more. I'll look into it soon. |
Collaborator
|
There is another PR up in which @gyfelton removes that check. I think once that lands we can rebase on top of that. |
Collaborator
|
@hborawski please merge the main branch, it should have been fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than have all dependency labels be absolute (
//Pods/SomePod) this experimental option generates labels to point to an external repository, allowing a more flexible folder structure, since yourPodsfolder doesn't need to be in the root//Pods/SomePod->@Pods//SomePodThis obviously needs to work in conjunction with a repository rule, which I have a basic implementation of that works, if theres a place I can PR that to, I'd be happy to do that
just trying to utilize this plugin for my situation without needing to maintain a fork
The project i'm working on is a multi platform mono-repo, so we want to be able to isolate the ios files into an
iosfolder, rather than polluting the root of the repo with pod related files