Use --output=streamed_proto if supported#117
Use --output=streamed_proto if supported#117illicitonion merged 2 commits intobazel-contrib:mainfrom
--output=streamed_proto if supported#117Conversation
--output=streamed_proto if available
--output=streamed_proto if available--output=streamed_proto if supported
This avoids reading a single giant proto message with all configured targets. Instead, Bazel streams out invidual length-delimited configured target protos, which is more memory efficient and also supports result sizes > 2GB.
|
@sitaktif Ready for review now, I had to run |
|
I tried the HEAD of main branch but got this error |
@fmeum Have you got time to take a look at this? Thank you. |
|
@honnix How are you using target-determinator? Can you reproduce this on a small project? |
Very basic usage of target-determinator. I tested using this command That said we have tons of stuff in |
|
Actually if I try to upgrade bazel used by this repo to 8.4.0, I could already see the same issue. |
Did this happen when you run the tests? I can't reproduce the issue in that way. I haven't used target-determinator yet, so if you can share the exact command to run on its repo, that would be appreciated. :-) |
|
Sure.
|
No it doesn't happen with tests because I think everything is running under Bazel 7.5.0: target-determinator/.bazelversion Line 1 in 1e25331 |
This avoids reading a single giant proto message with all configured targets. Instead, Bazel streams out invidual length-delimited configured target protos, which is more memory efficient and also supports result sizes > 2GB.