Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the README to modernize the getting started instructions and provide comprehensive documentation for rules_perl. The changes add Bzlmod support alongside legacy WORKSPACE instructions and expand the documentation significantly.
Key Changes:
- Added Bzlmod (MODULE.bazel) setup instructions as the recommended approach
- Expanded platform support section with detailed compatibility information
- Added complete reference documentation for all available rules (perl_binary, perl_library, perl_test, perl_xs)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@UebelAndre @nigelgbanks @simeonwarren - if you guys have time, I'd appreciate a review of the README update. |
| bazel_dep(name = "rules_perl", version = "0.1.0") # Use appropriate version | ||
|
|
||
| # Register toolchains | ||
| perl = use_extension("@rules_perl//perl:extensions.bzl", "perl") |
There was a problem hiding this comment.
That doesn't seem right
- There is no such extension
You cannot register toolchains using extensions if I remember correctly(that's false)
To register toolchains you just need to use register_toolchains("@rules_perl//perl:all")
There was a problem hiding this comment.
I think this would make sense to have though. Most rules use this pattern to define toolchains so it's understandable that was the assumption here.
There was a problem hiding this comment.
The problem is that it's not correct - current rules do not work like that
|
|
||
| **Attributes:** | ||
|
|
||
| | Attribute | Type | Description | Default | |
There was a problem hiding this comment.
Did you write it manually?
You can generate API documentation using stardoc, it's a pretty good tool
There was a problem hiding this comment.
I used AI to speed things along and it shows. I'll check that out - Thanks
3 participants
No description provided.