fix kmr_04 Goompa cutscene re-enabling player input#164
Open
DevRubicate wants to merge 1 commit intobates64:mainfrom
Open
fix kmr_04 Goompa cutscene re-enabling player input#164DevRubicate wants to merge 1 commit intobates64:mainfrom
DevRubicate wants to merge 1 commit intobates64:mainfrom
Conversation
Commit e761295 ("c foliage") refactored the inline include CheckPartnerFlags1000 into the AwaitPartnerGrounded API_CALLABLE and inadvertently flipped the boolean argument on the adjacent DisablePlayerInput call from true to false. The cutscene where Jr. Troopa attacks Goompa flows directly into the Jr. Troopa encounter cutscene before SpeakToPlayer locks the player, so Mario can walk around freely during both cutscenes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit e761295 ("c foliage") refactored the inline include CheckPartnerFlags1000 into the AwaitPartnerGrounded API_CALLABLE and inadvertently flipped the boolean argument on the adjacent DisablePlayerInput call from true to false. The cutscene where Jr. Troopa attacks Goompa flows directly into the Jr. Troopa encounter cutscene before SpeakToPlayer locks the player, so Mario can walk around freely during both cutscenes.