Bugfix/ws2812 initialisation (data-transfer rate)#6
Open
minimism wants to merge 2 commits intobastl-instruments:mainfrom
Open
Bugfix/ws2812 initialisation (data-transfer rate)#6minimism wants to merge 2 commits intobastl-instruments:mainfrom
minimism wants to merge 2 commits intobastl-instruments:mainfrom
Conversation
…n set to 176MHz (otherwise bit timing is incorrect for LEDs - running at 1.1MHz not 800kHz)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this fixes an issue I have seen when building the Wavebard firmware (1.6) on a new hardware platform (wonkystuff K2) with slightly different, 'WS2812-compatible' RGB LEDs.
In my experiments I found that the Neopixels were being driven at a data rate of 1.1MHz, rather than the specified maximum of 800kHz.
I discovered that this was because the global initialisation of the LEDs occurs before the clock-rate change (176MHz/125MHz == 1.4; 800kHz * 1.4 == 1.1MHz).
I've added a simple default initialiser to the WS2812 class for the global declaration, and then call the 'real' initialiser (which calls the important
ws2812_program_init) duringHardware::Init()