Add swing/humanize feature in Advanced Settings layer#4
Draft
tomasz-szymanek wants to merge 1 commit intobastl-instruments:mainfrom
Draft
Add swing/humanize feature in Advanced Settings layer#4tomasz-szymanek wants to merge 1 commit intobastl-instruments:mainfrom
tomasz-szymanek wants to merge 1 commit intobastl-instruments:mainfrom
Conversation
Author
|
@xx0x Hello, I will be grateful for any advice, or even a quick look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces rhythmic expression tools to the WaveBard sample player by adding Swing and Humanize functionalities. A new control is mapped to the Settings layer (Pot 6), allowing users to either delay even steps for a rhythmic swing (55%–100% range) or apply pseudo-random timing offsets using a predefined pattern to simulate natural playing imperfections (0%–45% range). The implementation includes an updated trigger mechanism in the AudioLoop to handle clock-based delays and provides visual feedback via LED 1, which changes color to indicate the active mode. Additionally, the AppWaveBard class has been expanded with the necessary state variables and logic to manage these delayed trigger events seamlessly.