fix: register routes inside Nova::serving to ensure middleware aliases exist#89
Open
milan607 wants to merge 1 commit intobastihilger:masterfrom
Open
fix: register routes inside Nova::serving to ensure middleware aliases exist#89milan607 wants to merge 1 commit intobastihilger:masterfrom
milan607 wants to merge 1 commit intobastihilger:masterfrom
Conversation
…s exist Routes were being registered in app->booted() which can run before Nova's middleware aliases (nova) are registered, causing errors when the middleware cannot be found. Moving route registration inside Nova::serving() ensures Nova is fully bootstrapped before we reference its middleware. Fixes route registration timing issue when Nova's service provider boots after the package's service provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes were being registered in
app->booted()which can run before Nova's middleware aliases (nova) are registered, causing errors when the middleware cannot be found.Moving route registration inside
Nova::serving()ensures Nova is fully bootstrapped before we reference its middleware.Problem
When the package's service provider boots before Nova's service provider, the
novamiddleware alias doesn't exist yet, causing route registration to fail.Solution
Register routes inside
Nova::serving()callback instead ofapp->booted(), ensuring Nova is fully initialized.Changes
$this->routes()call fromapp->booted()intoNova::serving()callback