Yet another WinML DLL Hell fix. Writing notes by hand to save tokens#16
Merged
Yet another WinML DLL Hell fix. Writing notes by hand to save tokens#16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So....for some reason pyke-ort's fetch ORT shat the bed and now we need to use dynamic libraries. As someone who spent two or three years working with ONNX Runtime, this isn't that big of a deal, but it's annoying that this is a chore again.
At any rate, since the next release is going to have ONNX Runtime support since I have plans for a product, we should make sure this works well.