refactor(retry): server retry use tenacity#2254
Open
salignatmoandal wants to merge 2 commits intobasetenlabs:mainfrom
Open
refactor(retry): server retry use tenacity#2254salignatmoandal wants to merge 2 commits intobasetenlabs:mainfrom
tenacity#2254salignatmoandal wants to merge 2 commits intobasetenlabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
truss/templates/server/common/retry.pywith tenacity.tenacitytotruss/templates/server/requirements.txtso the server runtime has the dependency when building/running the image.This addresses the existing TODO in the file and aligns the server template with the rest of the codebase, which already uses tenacity (e.g.
truss_handle,remote/baseten/service, control server).How
tenacity.Retryingwith:stop_after_attempt(count + 1)for the same total number of attempts (1 initial +countretries).wait_fixed(gap_seconds)for the delay between attempts.before_sleepcallback to log the same messages as before ("Retrying..." on first failure, "Retry count: N" on subsequent ones).reraise=Trueso the original exception is propagated after the last failure.tenacity>=8.0.1(aligned with the version in the project rootpyproject.toml).The public API of
retry()is unchanged, so no updates were needed inmodel_wrapper.py.Testing
uv run pytest truss/tests/templates/server/common/test_retry.py -v— 5/5 passed.