fix: validate eth_sendTransaction response is a tx hash not a signature#263
Open
ygd58 wants to merge 1 commit intobase:masterfrom
Open
fix: validate eth_sendTransaction response is a tx hash not a signature#263ygd58 wants to merge 1 commit intobase:masterfrom
ygd58 wants to merge 1 commit intobase:masterfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
Author
|
@fan-zhang-sv @spencerstock Could you please review this PR? It adds validation for eth_sendTransaction response. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using the
baseAccountwagmi connector,eth_sendTransactionsometimes returns a 65-byte ECDSA signature instead of a standard 32-byte transaction hash. This causeswaitForTransactionReceipt()to fail with:Root Cause
In
handleResponse(),eth_sendTransactionfell through to thedefaultcase with no validation.Fix
Added validation in
handleResponse()that checks the response is a valid 32-byte tx hash (66 hex chars). If the popup returns a signature instead, a clear error is thrown immediately.Testing
Closes #251