Add "types" to package.json exports to fix module type resolution#264
Open
trevorsmith wants to merge 1 commit intobalazsbotond:masterfrom
Open
Add "types" to package.json exports to fix module type resolution#264trevorsmith wants to merge 1 commit intobalazsbotond:masterfrom
trevorsmith wants to merge 1 commit intobalazsbotond:masterfrom
Conversation
Jack-Works
suggested changes
Jan 27, 2024
Jack-Works
left a comment
There was a problem hiding this comment.
this change is wrong.
".": {
"import": { "types": "./dist/index.d.ts", "default": "./dist/index.mjs" },
"require": { "types": "./dist/index.d.ts", "default": "./dist/index.js" }
}this is correct (not strictly, but reasonably correct). you may want to know more about how the ordering is important, and how "types" in "exports" actually work.
|
any plans to merge? |
|
Are there any plans to merge that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the following Typescript error: