Merged
Conversation
jmleroux
force-pushed
the
phpunit
branch
2 times, most recently
from
a8845b6 to
54ca1f7
Compare
Closed
jmleroux
commented
Oct 13, 2025
garak
requested changes
Oct 14, 2025
Contributor
Author
Aaaargghh, another drawback of prebuilt images. Our php82 is not up to date. 😢 https://github.com/badges/poser/actions/runs/18503497058/job/52726362613?pr=113#step:6:13 I can offer two options:
|
Contributor
Author
|
Option 1 already done in #114 |
garak
reviewed
Oct 24, 2025
Contributor
Author
|
I think it's ready to merge. |
garak
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert all specs to PhpUnit tests.