Skip to content

chore(tech-insights): remove unused uuid and @types/uuid dependency#8400

Open
christoph-jerolimov wants to merge 1 commit intobackstage:mainfrom
christoph-jerolimov:tech-insights/uuid
Open

chore(tech-insights): remove unused uuid and @types/uuid dependency#8400
christoph-jerolimov wants to merge 1 commit intobackstage:mainfrom
christoph-jerolimov:tech-insights/uuid

Conversation

@christoph-jerolimov
Copy link
Copy Markdown
Member

Hey, I just made a Pull Request!

Hi @Xantier @punkle @maicaballangan,

from time to time I try to check and cleanup old PRs, this time I saw #7789 and saw that your plugin is actually not using the uuid library. (I found it just in the knip report, not in the source code.)

To this PR removes it from tech-insights, updates the knip-reports and enables the automated knip-report checks in bcp.json.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@christoph-jerolimov christoph-jerolimov self-assigned this Apr 2, 2026
@backstage-service backstage-service added the workspace/tech-insights Used to tag tech-insights workspace issues and pull requests label Apr 2, 2026
@backstage-goalie
Copy link
Copy Markdown
Contributor

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage-community/plugin-tech-insights-backend-module-jsonfc
  • @backstage-community/plugin-tech-insights-common
  • @backstage-community/plugin-tech-insights-maturity-common
  • @backstage-community/plugin-tech-insights-maturity
  • @backstage-community/plugin-tech-insights-node
  • @backstage-community/plugin-tech-insights-react
  • @backstage-community/plugin-tech-insights

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/tech-insights/packages/app none v0.0.11
backend workspaces/tech-insights/packages/backend none v0.0.11
@backstage-community/plugin-tech-insights-backend-module-jsonfc workspaces/tech-insights/plugins/tech-insights-backend-module-jsonfc none v0.7.2
@backstage-community/plugin-tech-insights-backend workspaces/tech-insights/plugins/tech-insights-backend patch v2.5.2
@backstage-community/plugin-tech-insights-common workspaces/tech-insights/plugins/tech-insights-common none v0.8.2
@backstage-community/plugin-tech-insights-maturity-common workspaces/tech-insights/plugins/tech-insights-maturity-common none v0.4.2
@backstage-community/plugin-tech-insights-maturity workspaces/tech-insights/plugins/tech-insights-maturity none v0.6.5
@backstage-community/plugin-tech-insights-node workspaces/tech-insights/plugins/tech-insights-node none v2.6.2
@backstage-community/plugin-tech-insights-react workspaces/tech-insights/plugins/tech-insights-react none v1.4.0
@backstage-community/plugin-tech-insights workspaces/tech-insights/plugins/tech-insights none v1.2.0

Copy link
Copy Markdown
Member

@kurtaking kurtaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the clean up efforts 🙏

I thought enabling Knip reports would block CI because there are errors in the report. Do you know why this is not true?

@christoph-jerolimov
Copy link
Copy Markdown
Member Author

Hey, the knip report option just enforce that these files represent "the truth". It's helpful in a way that if you add code that depends on a new library you must add them. Or if you remove the usage of a library you are enforced to remove it from package.json.

There are some false mentioned there esp when you have a test app (packages/app and packages/backend). But from my experience it works perfectly for everything in plugins.

So on your case here more dependencies could be dropped but yes, it does not break the ci.

For me it's like the report api. Its a good helper to make changes to dependencies (or the api) visible in reviews.

@kurtaking
Copy link
Copy Markdown
Member

Hey, the knip report option just enforce that these files represent "the truth". It's helpful in a way that if you add code that depends on a new library you must add them. Or if you remove the usage of a library you are enforced to remove it from package.json.

There are some false mentioned there esp when you have a test app (packages/app and packages/backend). But from my experience it works perfectly for everything in plugins.

So on your case here more dependencies could be dropped but yes, it does not break the ci.

For me it's like the report api. Its a good helper to make changes to dependencies (or the api) visible in reviews.

Thank you for the explanation and comparison 🙏 PR looks good to me. Let's 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workspace/tech-insights Used to tag tech-insights workspace issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants