chore(tech-insights): remove unused uuid and @types/uuid dependency#8400
chore(tech-insights): remove unused uuid and @types/uuid dependency#8400christoph-jerolimov wants to merge 1 commit intobackstage:mainfrom
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
…see backstage#7789) Signed-off-by: Christoph Jerolimov <[email protected]>
989eb1b to
d7fe915
Compare
kurtaking
left a comment
There was a problem hiding this comment.
Hey, thanks for the clean up efforts 🙏
I thought enabling Knip reports would block CI because there are errors in the report. Do you know why this is not true?
|
Hey, the knip report option just enforce that these files represent "the truth". It's helpful in a way that if you add code that depends on a new library you must add them. Or if you remove the usage of a library you are enforced to remove it from package.json. There are some false mentioned there esp when you have a test app (packages/app and packages/backend). But from my experience it works perfectly for everything in plugins. So on your case here more dependencies could be dropped but yes, it does not break the ci. For me it's like the report api. Its a good helper to make changes to dependencies (or the api) visible in reviews. |
Thank you for the explanation and comparison 🙏 PR looks good to me. Let's 🚢 |
Hey, I just made a Pull Request!
Hi @Xantier @punkle @maicaballangan,
from time to time I try to check and cleanup old PRs, this time I saw #7789 and saw that your plugin is actually not using the uuid library. (I found it just in the knip report, not in the source code.)
To this PR removes it from tech-insights, updates the knip-reports and enables the automated knip-report checks in bcp.json.
✔️ Checklist
Signed-off-byline in the message. (more info)