Update changesets action - #10879
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The workflow updates are consistent with the refreshed action’s documented inputs (including versionBranch) and cleanly remove an input that no longer exists.
Pull request overview
Pins the workspace release workflows to a refreshed backstage/changesets-action commit (based on the v1.9.0 upstream baseline with versionBranch support) and removes a now-obsolete input to align with the updated action interface.
Changes:
- Update
backstage/changesets-actionpin from the previous SHA to796f06fde86f6539cdacf7c38dad62ac20e26853. - Remove
skipRootChangelogUpdate, which is no longer an input in the refreshed action. - Keep
versionBranchconfigured to preserve independent workspace release PR branch naming.
File summaries
| File | Description |
|---|---|
| .github/workflows/release_workspace.yml | Pins backstage/changesets-action to the refreshed commit and removes the obsolete skipRootChangelogUpdate input. |
| .github/workflows/release_workspace_version.yml | Same action pin update and input removal for the maintenance/versioned workspace release workflow. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
4659d14 to
a5eca0b
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The updated action version supports versionBranch and no longer defines skipRootChangelogUpdate, so the workflow changes are consistent and low-risk.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
a5eca0b to
7d50aa4
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The if: condition for the Version Packages PR step in release_workspace.yml is logically ineffective as written and should be corrected to reflect the intended gating behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
| @@ -94,13 +94,17 @@ jobs: | |||
| - name: Update Version Packages (${{ inputs.workspace }}) PR | |||
| id: changesets-pr | |||
| if: steps.release_check.outputs.needs_release != 'true' || inputs.force_release != true | |||
|
Marking this as draft until backstage/changesets-action#22 is merged and the v3.0.0 release has been published. Once that release exists, we can update both workflow references to the immutable commit behind the v3.0.0 tag rather than pinning a pre-release PR commit. |
Hey, I just made a Pull Request!
Pin both workspace release workflows to the refreshed v1.9.0-based Backstage action and remove the obsolete skipRootChangelogUpdate input. The fork now differs from upstream only by the versionBranch input required for independent workspace release PR branches.
Both workflows also provide a signed-off commit message so action-generated version commits satisfy this repository's DCO requirement, including prerelease mode.
Depends on backstage/changesets-action#22.
✔️ Checklist