feat(packages): implement multiple mnemonic, single passsword and guard support#1185
Merged
jrwbabylonlab merged 7 commits intomainfrom Mar 3, 2026
Merged
Conversation
🔐 Commit Signature Verification✅ All 7 commit(s) passed verification
Summary
Required key type: Last verified: 2026-03-03 03:13 UTC |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e054325602
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
gbarkhatov
previously approved these changes
Mar 2, 2026
gbarkhatov
previously approved these changes
Mar 2, 2026
jrwbabylonlab
approved these changes
Mar 3, 2026
fix(vault): depositor as claimer improvements (#1188)
94dc947 to
2d47d40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a Mnemonic
flowchart TD A[User adds a mnemonic] --> B{localStorage empty?} B -->|YES| C[Encrypt mnemonic with password] C --> D[Store mnemonic + save password verifier] D --> E[Done ✓] B -->|NO| F{Password matches existing?} F -->|NO| G[Rejected ✗] F -->|YES| H{Same mnemonic already stored?} H -->|YES| I[Return existing ID] H -->|NO| J[Add as new entry] J --> EUnlocking for a Peg-in
flowchart TD A[User resumes a peg-in] --> B{Peg-in mapping exists AND mnemonic is in localStorage?} B -->|YES| C[User enters password] C --> D[Decrypt mapped mnemonic] D --> E[Submit Lamport key] E --> F{Succeeded?} F -->|YES| G[Done ✓] F -->|NO| H[Show import form] B -->|NO| H H --> I[User types 12 words + enters password] I --> J[Store mnemonic + link to peg-in] J --> K[Submit Lamport key] K --> GForgot Password
flowchart TD A[User forgot password] --> B[Clear localStorage] B --> C[Re-import mnemonic/s with new password] C --> D[Peg-in links rebuilt when deposits are resumed] D --> E[Done ✓]