This repository was archived by the owner on Nov 4, 2021. It is now read-only.
Allow specification of elements other than body#359
Open
soranoba wants to merge 1 commit into
Open
Conversation
soranoba
force-pushed
the
feature/additional-params
branch
2 times, most recently
from
51aaa71 to
4191b65
Compare
soranoba
force-pushed
the
feature/additional-params
branch
from
4191b65 to
7a8acf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some parameters that we can specify in
Elasticsearch\Clientbut not in this library.e.g. one of the strategies to improve performance is to limit the shards by specifying routing, but it cannot with this library.
This PR provides a way to specify these in case of using SingleIndexer.
I think that it is difficult to specify in the case of using BulkIndexer, so it do not support it at this time.
I welcome editing of this PR by maintainers.
Thanks.