fix(Core/Scripts): Fix Ragnaros combat evade after Wrath of Ragnaros knockback

[blinkysc]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

AI-assisted Pull Requests

Important

While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.

Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.

• AI tools (e.g. ChatGPT, Claude, or similar) were used entirely or partially in preparing this pull request. Please specify which tools were used, if any.
  • Claude Code with AzerothMCP

Issues Addressed:

• Closes [Raid] Molten Core - Ragnaros Combat Bug (Wrath of Ragnaros) chromiecraft/chromiecraft#9225
• Closes [Raid] Molten Core - Ragnaros Combat Bug (General) chromiecraft/chromiecraft#9226

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found
  • Adapted from TrinityCore's Ragnaros script (offl's rewrite in TrinityCore#31549)

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. .go xyz 838.31 -831.47 -232.19 409
2. .instance setbossstate 8 3
3. .npc add temp 12018
4. .npc set faction 1080
5. .npc set flag 1
6. Talk to Majordomo to trigger Ragnaros summon
7. Engage Ragnaros in melee
8. Wait for Wrath of Ragnaros (spell 20566) to knockback all players out of melee range
9. Before fix: Ragnaros evades and resets the encounter
10. After fix: Ragnaros stays in combat and casts Magma Blast (spell 20565) on random targets until players re-enter melee range

Known Issues and TODO List:

• Verify submerge/emerge cycle still functions correctly after the timer changes
• Verify Magma Blast does not fire when a player is in melee range

Description

The old Ragnaros script used CanAIAttack to restrict valid targets to melee range, then intercepted EnterEvadeMode to cast Magma Blast when no melee targets existed. This design became incompatible with the new threat system port, which uses CanAIAttack to determine threat entry online/offline status. When all players were knocked back:

1. CanAIAttack returned false for everyone → all threat entries marked offline
2. IsThreatListEmpty() (default: excludes offline) returned true → Ragnaros fully evaded
3. Even with a fix to include offline entries, SelectTarget/DoCastRandomTarget skipped offline entries → Magma Blast couldn't find targets

The fix adapts TrinityCore's approach: Magma Blast is now a regular repeating event (4s) that checks IsWithinMeleeRange before casting. CanAIAttack and the custom EnterEvadeMode are removed entirely, so the threat system operates normally.