Skip to content

Update pet_dk.cpp#25323

Open
cameronjohnson17 wants to merge 1 commit intoazerothcore:masterfrom
cameronjohnson17:feature/balanceGargoyle
Open

Update pet_dk.cpp#25323
cameronjohnson17 wants to merge 1 commit intoazerothcore:masterfrom
cameronjohnson17:feature/balanceGargoyle

Conversation

@cameronjohnson17
Copy link
Copy Markdown

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • [x ] Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

balance Gargoyle Strike for better game play, smarter AI.

AI-assisted Pull Requests

Important

While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.

Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.

  • AI tools (e.g. ChatGPT, Claude, or similar) were used entirely or partially in preparing this pull request. Please specify which tools were used, if any.

Issues Addressed:

Currently Gargoyle strike does not align with the original intent. applied fix for better game play.

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. Create a Death Knight
  2. Get to Level 80
  3. Use Unholy DK Talent Build
  4. Summon Gargoyle

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

balance Gargoyle Strike for better game play.
@heyitsbench
Copy link
Copy Markdown
Contributor

Source?

@github-actions github-actions bot added Script Refers to C++ Scripts for the Core file-cpp Used to trigger the matrix build labels Mar 30, 2026
@TheSCREWEDSoftware TheSCREWEDSoftware added the Waiting For More Info from Author Issue pending due to needing more additional information from the author label Mar 31, 2026
@cameronjohnson17
Copy link
Copy Markdown
Author

cameronjohnson17 commented Mar 31, 2026

Hello,

The current implementation uses a 2.4s cast, which diverges from the original retail WotLK client. This patch lowers the delay toward 2.0s to restore parity with legacy behavior and reduce confusion among players and maintainers.

Gargoyle strike cast time: 2 seconds, https://www.wowhead.com/wotlk/spell=51963/gargoyle-strike

Original retail WotLK footage shows Gargoyle Strike with a 2.0s base cast: https://www.youtube.com/watch?v=jA5I7jCqyfg

When common speed buffs are active (Unholy Presence, Icy Talons, Bloodlust, Windfury Totem), the effective cast is reduced: 2.0 / (1.15 * 1.20 * 1.30 * 1.16) = 0.96s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

file-cpp Used to trigger the matrix build Script Refers to C++ Scripts for the Core Waiting For More Info from Author Issue pending due to needing more additional information from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants