Skip to content

fix(Core/Spells): Resolve pet to owner in EffectSummonType default path#25322

Open
blinkysc wants to merge 1 commit intoazerothcore:masterfrom
blinkysc:fix-pet-combat-state-assert
Open

fix(Core/Spells): Resolve pet to owner in EffectSummonType default path#25322
blinkysc wants to merge 1 commit intoazerothcore:masterfrom
blinkysc:fix-pet-combat-state-assert

Conversation

@blinkysc
Copy link
Copy Markdown
Contributor

@blinkysc blinkysc commented Mar 30, 2026

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Extends the pet-to-owner resolution from SummonGuardian (added in #25266) to the default summon path in EffectSummonType. When a pet casts a summon spell with properties that route through the default path (e.g. Category=ALLY, Type=NONE), the summoned creature was incorrectly owned by the pet instead of the player.

AI-assisted Pull Requests

  • AI tools (e.g. ChatGPT, Claude, or similar) were used entirely or partially in preparing this pull request: Claude Code (Anthropic) with AzerothMCP

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick).

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. Play as a Death Knight or Hunter with an active pet
  2. Have the pet get the killing blow on a creature that cross-casts a summon spell on death via SAI (SMART_ACTION_CROSS_CAST with SMART_TARGET_ACTION_INVOKER) where the summon properties route through the default EffectSummonType path (e.g. Category=ALLY, Type=NONE)
  3. Verify the summoned creature is owned by the player, not the pet

Known Issues and TODO List:

  • [ ]
  • [ ]

@blinkysc blinkysc marked this pull request as draft March 30, 2026 22:52
Extends the pet-to-owner resolution from SummonGuardian to the default
summon path in EffectSummonType. When a pet casts a summon spell with
properties that route through the default path (e.g. Category=ALLY,
Type=NONE), the summoned creature was incorrectly owned by the pet
instead of the player.
@blinkysc blinkysc force-pushed the fix-pet-combat-state-assert branch from 6af8d85 to 167311a Compare March 30, 2026 22:54
@blinkysc blinkysc changed the title fix(Core/Combat): Guard UpdatePetCombatState against pet owners fix(Core/Spells): Resolve pet to owner in EffectSummonType default path Mar 30, 2026
@blinkysc blinkysc marked this pull request as ready for review March 30, 2026 22:54
@github-actions github-actions bot added CORE Related to the core file-cpp Used to trigger the matrix build labels Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE Related to the core file-cpp Used to trigger the matrix build Ready to be Reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants