fix(Core/Spells): Resolve pet to owner in EffectSummonType default path#25322
Open
blinkysc wants to merge 1 commit intoazerothcore:masterfrom
Open
fix(Core/Spells): Resolve pet to owner in EffectSummonType default path#25322blinkysc wants to merge 1 commit intoazerothcore:masterfrom
blinkysc wants to merge 1 commit intoazerothcore:masterfrom
Conversation
Extends the pet-to-owner resolution from SummonGuardian to the default summon path in EffectSummonType. When a pet casts a summon spell with properties that route through the default path (e.g. Category=ALLY, Type=NONE), the summoned creature was incorrectly owned by the pet instead of the player.
6af8d85 to
167311a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Extends the pet-to-owner resolution from
SummonGuardian(added in #25266) to the default summon path inEffectSummonType. When a pet casts a summon spell with properties that route through the default path (e.g.Category=ALLY,Type=NONE), the summoned creature was incorrectly owned by the pet instead of the player.AI-assisted Pull Requests
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List: