fix(Scripts/VioletHold): Fix Ethereal Sphere speed in Xevozz encounter#25313
Open
blinkysc wants to merge 1 commit intoazerothcore:masterfrom
Open
fix(Scripts/VioletHold): Fix Ethereal Sphere speed in Xevozz encounter#25313blinkysc wants to merge 1 commit intoazerothcore:masterfrom
blinkysc wants to merge 1 commit intoazerothcore:masterfrom
Conversation
Ethereal Spheres were inheriting Xevozz's movement speed via MoveFollow's default inheritSpeed=true, causing them to move at boss speed instead of their own slow speed_run (0.42857). Pass inheritSpeed=false so spheres use their creature_template speed. Closes azerothcore#25242
Contributor
|
Unsure if this may or not require a sniff to validate the c.t has the correct values (even if script has it fixed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
AI-assisted Pull Requests
Important
While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.
Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.
Issues Addressed:
SOURCE:
The changes have been validated through:
Description
After #25085 (
fix(Core/Movement): followers match their target's motion speed),MoveFollowdefaults toinheritSpeed=true. This causes creature-to-creature follows to inherit the target's speed. The Ethereal Spheres summoned by Xevozz now inherit his run speed (1.71429) instead of using their own slowspeed_runfromcreature_template(0.42857), making them ~4x faster than intended and impossible to kite.The fix passes
inheritSpeed=falsetoMoveFollowso spheres use their owncreature_templatespeed.Tests Performed:
This PR has been:
How to Test the Changes:
.tele violet holdKnown Issues and TODO List:
MoveFollowfor deliberately slow creatures may need the sameinheritSpeed=falsefix after fix(Core/Movement): followers match their target's motion speed #25085